fix flake8 warnings#10995
Closed
danieleades wants to merge 1 commit intosphinx-doc:masterfrom
Closed
Conversation
danieleades
force-pushed
the
flake8-fixes
branch
from
9a45fee to
564ac0d
Compare
Contributor
Author
|
python 3.12 is still failing. perhaps that should be configured to not fail the CI until that's stabilised? |
jfbu
added a commit
to jfbu/sphinx
that referenced
this pull request
Nov 30, 2022
danieleades
force-pushed
the
flake8-fixes
branch
from
ddbaf04 to
a15dac5
Compare
danieleades
force-pushed
the
flake8-fixes
branch
from
a15dac5 to
ad437b0
Compare
This was referenced Dec 15, 2022
Closed
jfbu
added a commit
to jfbu/sphinx
that referenced
this pull request
Dec 16, 2022
jfbu
added a commit
that referenced
this pull request
Dec 16, 2022
* fix flake8 warnings * Deactivate (provisorily) testing with 3.12-dev (refs: #10995 (comment) ) * Escape # in tox.ini for tox 4 compatibility ('du-latest' tests) Co-authored-by: Daniel Eades <[email protected]>
Contributor
|
I merged your commit to master via #11035, unfortunately it got squashed with my commit deactivating Python 3.12-dev testing and fixing |
Contributor
|
Sorry I can not force-push to master to fix my squashing mistake Really sorry, there is bug in github regarding the Co-authored-by line as well which contradicts other policy. My apologies about his, I had set-up the damn thing to rebase and merge but it got reset on CI completion and I clicked too quickly without checking. |
Contributor
Author
|
No problem at all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like there's a few flake8 warnings on master. This PR aims to address those.
The errors stem from the use of type comments. These comments are non-standard syntax, though they are supported by the PyCharm IDE.
Unfortunately pylance, mypy, and flake8 don't like them.
without type comments, it's not possible to type annotate 'for' loops on untyped iterators, so in these instances I've suppressed warnings rather than removing the type comments. Possibly there's a better long term solution, but hopefully this gets the CI working again and starts putting some nice green ticks next to the pull requests.