@jschueller please don't force-push, I'll squash on merge.

A

oh, ok

Please may you add some tests for the new behaviour, and an entry in CHANGES?

A

As a design point, I'd suggest splitting render_math() into two functions, at the # Move generated image on tempdir to build dir line.

We would always call the function that creates the temporary image, but the flag would control if we called the move_rendered_image_from_temp_dir_to_build_dir() function or the read_rendered_image_and_return_base_64_encoded_string() function (names to be improved!).

This then means we always know the mime type and don't have to use the guess functions, and don't need to remove any images, as they're in temp directories anyway.

A

@AA-Turner the move is now in a separate function get_img_src, but I dont have as many functions as suggested,
could you give more details on how to split the functions if its not ok for you ?

Thanks Julien!

A

thanks!

@AA-Turner it seems it does not work in parallel (using -j4 flag), any idea why ?

File "/usr/lib/python3.10/site-packages/sphinx/util/parallel.py", line 125, in _join_one
    raise SphinxParallelError(*result)
sphinx.errors.SphinxParallelError: FileNotFoundError: [Errno 2] No such file or directory: '/home/devel/project/build/python/src/sphinx_build/html/_images/math/dd25924f1cd0f37c1985116c759fb5c0dbfae2bb.svg'

Could you open a new issue please, or a PR adding a failing test for parallel building?

A

ok, see #10869