-
-
Notifications
You must be signed in to change notification settings - Fork 24
Detect roles that start with !~
#146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect roles that start with !~
#146
Conversation
|
I missed you had implemented it so I did it on my side too, sorry. Comparing your implem and mine: #150 looks like I'm detecting |
|
@JulienPalard |
|
I'd gladly merge your PR if you'd like your first PR here to be merged, if you're short in time I'll merge mine, just tell me. |
|
@JulienPalard Thanks. If it's fine, I’d be happy to have my first PR merged here. |
|
Then you can tweak it to spot |
|
@JulienPalard Just updated. It now detects both |
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thanks! :) |
This PR adds logic to detect roles that start with
!~, which are not rendered correctly.closes: gh-126