Skip to content

Conversation

@mushitoriami
Copy link
Contributor

This PR adds logic to detect roles that start with !~, which are not rendered correctly.

closes: gh-126

@JulienPalard
Copy link
Collaborator

I missed you had implemented it so I did it on my side too, sorry.

Comparing your implem and mine: #150 looks like I'm detecting !~ and ~!, do you think it's an interesting feature to keep?

@mushitoriami
Copy link
Contributor Author

@JulienPalard ~! doesn't work as expected either, so it makes sense to detect it as well.

@JulienPalard
Copy link
Collaborator

I'd gladly merge your PR if you'd like your first PR here to be merged, if you're short in time I'll merge mine, just tell me.

@mushitoriami
Copy link
Contributor Author

@JulienPalard Thanks. If it's fine, I’d be happy to have my first PR merged here.

@JulienPalard
Copy link
Collaborator

Then you can tweak it to spot ~! and !~, don't hesitate to steal my regex (in #150).

@mushitoriami
Copy link
Contributor Author

@JulienPalard Just updated. It now detects both ~! and !~.

mushitoriami and others added 2 commits November 7, 2025 12:02
Copy link
Collaborator

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JulienPalard JulienPalard merged commit 833d320 into sphinx-contrib:main Nov 7, 2025
20 of 22 checks passed
@JulienPalard
Copy link
Collaborator

Thanks! :)

@mushitoriami mushitoriami deleted the detect-exclamation-and-tilde branch November 8, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect !~ in roles

3 participants