Skip to content

Fix typo SPGLIB_OLD_ERROR_HANLDING#625

Merged
atztogo merged 4 commits intospglib:developfrom
atztogo:fix-typo
Dec 22, 2025
Merged

Fix typo SPGLIB_OLD_ERROR_HANLDING#625
atztogo merged 4 commits intospglib:developfrom
atztogo:fix-typo

Conversation

@atztogo
Copy link
Copy Markdown
Collaborator

@atztogo atztogo commented Dec 9, 2025

No description provided.

Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@atztogo
Copy link
Copy Markdown
Collaborator Author

atztogo commented Dec 9, 2025

Tests of spglib.error.OLD_ERROR_HANDLING and environment variable of SPGLIB_OLD_ERROR_HANDLING were added.

Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 slight organizational change.

@lan496
Copy link
Copy Markdown
Member

lan496 commented Dec 22, 2025

It seems we need to replace macos-13 runner with macos-15
actions/runner-images#13046

@LecrisUT
Copy link
Copy Markdown
Collaborator

It seems we need to replace macos-13 runner with macos-15 actions/runner-images#13046

We can just drop it. That macos version was just to cover intel-based macos which we could drop the support for and just address issues as they come through

@atztogo atztogo enabled auto-merge December 22, 2025 01:25
@atztogo atztogo disabled auto-merge December 22, 2025 01:25
@atztogo atztogo merged commit ac5d100 into spglib:develop Dec 22, 2025
34 of 36 checks passed
@atztogo atztogo deleted the fix-typo branch December 22, 2025 01:25
@atztogo
Copy link
Copy Markdown
Collaborator Author

atztogo commented Dec 22, 2025

We can just drop it.

I will make another PR to perform it. Thanks @lan496 and @LecrisUT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants