Split the spglib.spglib monolith into individual submodules#620
Merged
lan496 merged 8 commits intospglib:developfrom Nov 21, 2025
Merged
Split the spglib.spglib monolith into individual submodules#620lan496 merged 8 commits intospglib:developfrom
spglib.spglib monolith into individual submodules#620lan496 merged 8 commits intospglib:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #620 +/- ##
========================================
Coverage 74.05% 74.05%
========================================
Files 27 27
Lines 8018 8018
Branches 1643 1643
========================================
Hits 5938 5938
Misses 1603 1603
Partials 477 477
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@LecrisUT, can you resolve conflicts with upstream? |
LecrisUT
force-pushed
the
chore/split_more_source
branch
from
e6450fc to
f0e916f
Compare
Collaborator
Author
Member
Collaborator
Author
|
Nah it's ok. It's more work to rebase, but it's not too bad |
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
chore/split_more_source
branch
from
f0e916f to
d1962a5
Compare
lan496
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #619