Skip to content

Move the internal code to a separate module#619

Merged
lan496 merged 4 commits intospglib:developfrom
LecrisUT:chore/split_source
Nov 19, 2025
Merged

Move the internal code to a separate module#619
lan496 merged 4 commits intospglib:developfrom
LecrisUT:chore/split_source

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Nov 17, 2025

Long overdue chore, but I found that it helps with the other documentation changes to come

@LecrisUT LecrisUT requested review from atztogo and lan496 November 17, 2025 19:23
@LecrisUT LecrisUT added this to the 2.7 milestone Nov 17, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.51%. Comparing base (8aecedf) to head (4aaba66).
⚠️ Report is 57 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #619   +/-   ##
========================================
  Coverage    74.51%   74.51%           
========================================
  Files           26       26           
  Lines         7899     7899           
  Branches      1639     1638    -1     
========================================
  Hits          5886     5886           
  Misses        1534     1534           
  Partials       479      479           
Flag Coverage Δ
c_api 69.45% <ø> (ø)
fortran_api 52.96% <ø> (ø)
python_api 67.72% <ø> (ø)
unit_tests 11.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LecrisUT.

Copy link
Copy Markdown
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lan496 lan496 merged commit cb11bf2 into spglib:develop Nov 19, 2025
50 checks passed
@LecrisUT LecrisUT deleted the chore/split_source branch November 19, 2025 11:03
lan496 added a commit that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants