Skip to content

Update reference of Bilbao Crystallographic Server#616

Merged
lan496 merged 1 commit intospglib:developfrom
LecrisUT:chore/fix-link
Nov 18, 2025
Merged

Update reference of Bilbao Crystallographic Server#616
lan496 merged 1 commit intospglib:developfrom
LecrisUT:chore/fix-link

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Nov 10, 2025

@LecrisUT LecrisUT requested a review from atztogo November 10, 2025 13:05
@LecrisUT LecrisUT added this to the 2.7 milestone Nov 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.51%. Comparing base (a10e6e5) to head (8084ec3).
⚠️ Report is 68 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #616   +/-   ##
========================================
  Coverage    74.51%   74.51%           
========================================
  Files           26       26           
  Lines         7895     7899    +4     
  Branches      1638     1638           
========================================
+ Hits          5883     5886    +3     
  Misses        1534     1534           
- Partials       478      479    +1
Flag Coverage Δ
c_api 69.45% <ø> (ø)
fortran_api 52.96% <ø> (ø)
python_api 67.72% <ø> (+<0.01%) ⬆️
unit_tests 11.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atztogo
Copy link
Copy Markdown
Collaborator

atztogo commented Nov 10, 2025

As you wrote, I could not open the URL with HTTPS.

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Nov 10, 2025

As you wrote, I could not open the URL with HTTPS.

Yeah find-replace failure 😅

LecrisUT
LecrisUT commented Nov 10, 2025
View reviewed changes
@atztogo
Copy link
Copy Markdown
Collaborator

atztogo commented Nov 10, 2025

It seems that http://webbdcrista2.ehu.es/wiki/index.php/Articles doesn't exist. Since it is unclear how the bilbao crystallographic server will be migrated, shall we tentatively comment out the following?

The references of many useful papers are found in the [Articles page](http://webbdcrista2.ehu.es/wiki/index.php/Articles).

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Nov 10, 2025

Actually the whole site has broken links. Let's wait for them to settle down and we can come back to this

@LecrisUT LecrisUT removed this from the 2.7 milestone Nov 10, 2025
@lan496 lan496 mentioned this pull request Nov 10, 2025
Merged
@lan496
Copy link
Copy Markdown
Member

lan496 commented Nov 16, 2025

The website still only supports HTTP. I prefer to merge this PR since other PRs fail with such a non-essential reason

@atztogo
Copy link
Copy Markdown
Collaborator

atztogo commented Nov 16, 2025

The website still only supports HTTP. I prefer to merge this PR since other PRs fail with such a non-essential reason

I agree. @LecrisUT, could you comment out the following line?

[Articles page](http://webbdcrista2.ehu.es/wiki/index.php/Articles).

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Nov 16, 2025

Http only could be worked around, but the whole website being unnavigable 🤷 . What about pointing these to web archive? https://web.archive.org/web/20250505150336/https://www.cryst.ehu.es/wiki/index.php/Articles

@atztogo
Copy link
Copy Markdown
Collaborator

atztogo commented Nov 16, 2025

What about pointing these to web archive?

It is fine for me.

lan496
lan496 approved these changes Nov 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lan496 lan496 enabled auto-merge November 18, 2025 09:00
@lan496 lan496 disabled auto-merge November 18, 2025 09:01
@lan496 lan496 merged commit 8aecedf into spglib:develop Nov 18, 2025
49 checks passed
@LecrisUT LecrisUT deleted the chore/fix-link branch November 19, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atztogo atztogo atztogo approved these changes

@lan496 lan496 lan496 approved these changes

Assignees

@lan496 lan496

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bilbao Crystallographic Server link is down for a while

3 participants

@LecrisUT @atztogo @lan496