Update implementation of PR-610 and add the test#612
Merged
atztogo merged 3 commits intospglib:developfrom Nov 5, 2025
Merged
Conversation
Collaborator
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #612 +/- ##
===========================================
+ Coverage 74.49% 74.51% +0.01%
===========================================
Files 26 26
Lines 7894 7895 +1
Branches 1634 1638 +4
===========================================
+ Hits 5881 5883 +2
Misses 1534 1534
+ Partials 479 478 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lan496
approved these changes
Nov 5, 2025
Member
lan496
left a comment
lan496
left a comment
There was a problem hiding this comment.
LGTM for choosing clean basis vectors in getting space group types of XSG and FSG before identifying MSG. I think PR 610 did the latter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a simplified version of PR #610. A new test was added to validate the changes of PR #610 since I had forgotten about it. Locally, I verified that this test fails on the commit before #610.