Skip to content

Format pointer alignment#608

Merged
lan496 merged 2 commits intospglib:developfrom
lan496:left-pointer-alignment
Sep 15, 2025
Merged

Format pointer alignment#608
lan496 merged 2 commits intospglib:developfrom
lan496:left-pointer-alignment

Conversation

@lan496
Copy link
Copy Markdown
Member

@lan496 lan496 commented Sep 15, 2025

Clang-format from CI starts complaining about PointerAlignment somehow. This PR fixes the format issue.

@lan496 lan496 force-pushed the left-pointer-alignment branch from db4c87a to ef59250 Compare September 15, 2025 06:53
@lan496 lan496 marked this pull request as ready for review September 15, 2025 06:55
@lan496 lan496 requested review from LecrisUT and Copilot September 15, 2025 06:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a clang-format configuration issue by adding a PointerAlignment setting to maintain consistent pointer formatting style.

  • Adds PointerAlignment: Right to the .clang-format configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lan496 lan496 changed the title Format pointer alighnment Format pointer alignment Sep 15, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.48%. Comparing base (c159731) to head (ef59250).
⚠️ Report is 62 commits behind head on develop.

Files with missing lines Patch % Lines
src/debug.c 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #608   +/-   ##
========================================
  Coverage    74.48%   74.48%           
========================================
  Files           26       26           
  Lines         7888     7888           
  Branches      1634     1637    +3     
========================================
  Hits          5875     5875           
  Misses        1534     1534           
  Partials       479      479           
Flag Coverage Δ
c_api 69.42% <80.00%> (ø)
fortran_api 52.91% <57.14%> (ø)
python_api 67.34% <60.00%> (ø)
unit_tests 11.69% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lan496 lan496 requested a review from atztogo September 15, 2025 07:00
@lan496 lan496 merged commit 98d2137 into spglib:develop Sep 15, 2025
52 checks passed
@lan496 lan496 deleted the left-pointer-alignment branch September 15, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants