fix: Build python bindings in the build-dir spglib subdirectory#606
Merged
LecrisUT merged 6 commits intospglib:developfrom Sep 15, 2025
Merged
fix: Build python bindings in the build-dir spglib subdirectory#606LecrisUT merged 6 commits intospglib:developfrom
spglib subdirectory#606LecrisUT merged 6 commits intospglib:developfrom
Conversation
Collaborator
|
Ah, that makes sense. Curious, how does hardlink compare in that case? Other than that, we could probably simplify it by building the artifact in the |
DanielYang59
commented
Sep 15, 2025
LecrisUT
requested changes
Sep 15, 2025
LecrisUT
approved these changes
Sep 15, 2025
DanielYang59
changed the title
spglib subdirectory to fix symlink permission issue on Windows
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #606 +/- ##
========================================
Coverage 74.48% 74.48%
========================================
Files 26 26
Lines 7888 7888
Branches 1638 1637 -1
========================================
Hits 5875 5875
Misses 1534 1534
Partials 479 479
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LecrisUT
changed the title
spglib subdirectory to fix symlink permission issue on Windowsspglib subdirectory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #552
The original issue turns out to be Windows requires Admin to create symlink by default:
Tested on my Windows 11 24H2 machine