Conversation
|
I have no idea but am fine for it. |
|
Can you describe this PR's motivation? I think format rules for C, C++, Fortran, and Python are already in |
|
Different users may have different settings for indentation and line length; a formatter enforces the style, but it may bring big diffs, which will be reduced by editorcondfig as far as user’s editor supports it. And I found that currently clang-format and ruff do not modify EOL, CR vs CRLF, which is configurable by: |
|
I like the idea of this project, but it does overlap with spglib/.pre-commit-config.yaml Lines 18 to 22 in f255fca We are missing I would suggest punting this in favor of specialized tools that do overall formatting until it can be used for general language settings 1.
For now the IDEs should have support for Footnotes |
|
I am using neovim, which now natively supports EditorConfig but does not load configs from .clang-format etc unfortunately. (maybe there exists some plugins) That’s why I opened this PR for less surprising. |
LecrisUT
left a comment
There was a problem hiding this comment.
I thought that neovim would be reading the other files, but I guess not. Well from my view I'm fine with adding these, let's just make sure everything is consistent. If they manage to make the domain-specific parts work, it would be good to push the other tools to read this also.
- enforce EOL of LF - check editorconfig
We don't really use it and instead the plain sphinx commands should be used.
|
@e-kwsm I have made some changes to minimize the diffs, can you check if everything looks fine to you as well. |
|
Is it ready to merge? |
https://editorconfig.org/