Update document for (spg_)get_spacegroup_type_from_symmetry#593
Merged
atztogo merged 2 commits intospglib:developfrom Jun 22, 2025
Merged
Update document for (spg_)get_spacegroup_type_from_symmetry#593atztogo merged 2 commits intospglib:developfrom
atztogo merged 2 commits intospglib:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #593 +/- ##
========================================
Coverage 74.48% 74.48%
========================================
Files 26 26
Lines 7888 7888
Branches 1637 1637
========================================
Hits 5875 5875
Misses 1534 1534
Partials 479 479
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Sorry, I found |
lan496
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@LecrisUT, I could not build document locally. Could you tell me what is the best way to check the doc build?#584 revealed that the
latticeparameter of(spg_)get_spacegroup_type_from_symmetryis necessary to transform symmetry operations in a reasonable form when the matrix representations of those operations were obtained with respect to oblique basis vectors. Following this, the documentation has been updated.