PR to fix (python) get_spacegroup_type_from_symmetry#592
Merged
atztogo merged 2 commits intospglib:developfrom Jun 21, 2025
Merged
PR to fix (python) get_spacegroup_type_from_symmetry#592atztogo merged 2 commits intospglib:developfrom
atztogo merged 2 commits intospglib:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #592 +/- ##
===========================================
+ Coverage 74.46% 74.48% +0.01%
===========================================
Files 26 26
Lines 7887 7888 +1
Branches 1638 1638
===========================================
+ Hits 5873 5875 +2
- Misses 1532 1534 +2
+ Partials 482 479 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LecrisUT
approved these changes
Jun 21, 2025
Collaborator
Author
|
Comment: Theoretically it should be unnecessary to rely on basis vectors, but currently it is due to the specific implementation of space group type search in spglib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix the bug in the python interface of
get_spacegroup_type_from_symmetry. The bug is thatlatticeis not transposed.