Skip to content

fix(fortran): Rrmove unused unsigned C types#586

Merged
LecrisUT merged 1 commit intospglib:developfrom
e-kwsm:fortran
Jun 19, 2025
Merged

fix(fortran): Rrmove unused unsigned C types#586
LecrisUT merged 1 commit intospglib:developfrom
e-kwsm:fortran

Conversation

@e-kwsm
Copy link
Copy Markdown
Contributor

@e-kwsm e-kwsm commented Jun 16, 2025

fix #585

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.33%. Comparing base (fd90ab0) to head (a9158b4).
⚠️ Report is 24 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #586   +/-   ##
========================================
  Coverage    74.33%   74.33%           
========================================
  Files           26       26           
  Lines         7878     7878           
  Branches      1632     1630    -2     
========================================
  Hits          5856     5856           
  Misses        1541     1541           
  Partials       481      481           
Flag Coverage Δ
c_api 68.67% <ø> (ø)
fortran_api 50.96% <ø> (ø)
python_api 67.07% <ø> (ø)
unit_tests 11.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LecrisUT LecrisUT changed the title build(fortran): check if unsigned types are supported or not fix(fortran): Rrmove unused unsigned C types Jun 16, 2025
@LecrisUT LecrisUT added this to the 2.7 milestone Jun 16, 2025
@LecrisUT
Copy link
Copy Markdown
Collaborator

LecrisUT commented Jun 16, 2025

Awesome, thanks for this. I'll try to fix the test failure soon and then the automation will take over to merge this

@LecrisUT LecrisUT enabled auto-merge (squash) June 16, 2025 09:39
@LecrisUT LecrisUT merged commit 36a3938 into spglib:develop Jun 19, 2025
44 of 49 checks passed
@e-kwsm e-kwsm deleted the fortran branch June 19, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compilation error due to C_unsigned (flang 20)

2 participants