Skip to content

fix: Clang-format for latest version#570

Merged
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:pre-commit
Apr 23, 2025
Merged

fix: Clang-format for latest version#570
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:pre-commit

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

The formatting changes look decent to me, I think we should add them in.

- Move the configuration to pyprojet.toml
- Update clang-format requirement

Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT LecrisUT requested a review from atztogo April 23, 2025 10:37
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 71.25000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 74.34%. Comparing base (0218486) to head (a0c0d11).
Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
python/_spglib.c 78.72% 10 Missing ⚠️
src/symmetry.c 0.00% 0 Missing and 4 partials ⚠️
src/spglib.c 57.14% 0 Missing and 3 partials ⚠️
src/cell.c 0.00% 0 Missing and 2 partials ⚠️
src/mathfunc.c 0.00% 0 Missing and 2 partials ⚠️
src/refinement.c 83.33% 0 Missing and 1 partial ⚠️
src/spin.c 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #570   +/-   ##
========================================
  Coverage    74.34%   74.34%           
========================================
  Files           26       26           
  Lines         8069     8069           
  Branches      1696     1692    -4     
========================================
  Hits          5999     5999           
  Misses        1561     1561           
  Partials       509      509           
Flag Coverage Δ
c_api 68.68% <60.60%> (ø)
fortran_api 50.70% <60.60%> (ø)
python_api 67.71% <68.91%> (ø)
unit_tests 11.67% <12.12%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LecrisUT LecrisUT merged commit e19a12d into spglib:develop Apr 23, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants