refactor: Improved python test fixtures#556
Merged
LecrisUT merged 4 commits intospglib:developfrom Mar 5, 2025
Merged
Conversation
Closed
LecrisUT
force-pushed
the
fix/550
branch
3 times, most recently
from
627d941 to
1f851a1
Compare
LecrisUT
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #556 +/- ##
========================================
Coverage 74.34% 74.34%
========================================
Files 26 26
Lines 8069 8069
Branches 1691 1689 -2
========================================
Hits 5999 5999
Misses 1561 1561
Partials 509 509
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LecrisUT
force-pushed
the
fix/550
branch
3 times, most recently
from
79db0b8 to
a03821f
Compare
Member
|
Packit-as-a-Service failed as always. Do we need to merge #558 first? |
Collaborator
Author
It will be broken for a while until scikit-build-core 0.11 lands in Fedora-rawhide. I'm waiting on a few dependencies and probably tomorrow will try to resolve them. |
Signed-off-by: Cristian Le <[email protected]>
- Convert everything to pytest - Moved generators to common fixtures
Collaborator
Author
|
/packit build |
lan496
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've ended up doing a heavy refactor of the testsuite:
.xzfilesunittesttopytestfixturespytest_generate_testsall tests are now expanded and can be selected individuallyCloses #550
Closes #291