Merged
Conversation
Collaborator
LecrisUT
commented
Nov 9, 2024
LecrisUT
commented
- bump gtest FetchContent version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #535 +/- ##
===========================================
+ Coverage 84.12% 84.24% +0.11%
===========================================
Files 26 26
Lines 8122 8209 +87
Branches 1702 1695 -7
===========================================
+ Hits 6833 6916 +83
- Misses 1289 1293 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
|
Can I merge this though testing-farm:fedra's fail? |
Collaborator
Author
|
Yes, I don't quite know the reason it failed there, but I'll have to refactor it later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.