Skip to content

Update references to spglib paper#534

Merged
atztogo merged 4 commits intospglib:developfrom
atztogo:update-ref-spglib
Nov 10, 2024
Merged

Update references to spglib paper#534
atztogo merged 4 commits intospglib:developfrom
atztogo:update-ref-spglib

Conversation

@atztogo
Copy link
Copy Markdown
Collaborator

@atztogo atztogo commented Nov 9, 2024

Updated references to the spglib paper, now published in the Science and Technology of Advanced Materials (STAM): Method journal.

@atztogo atztogo requested a review from lan496 November 9, 2024 05:13
@LecrisUT
Copy link
Copy Markdown
Collaborator

LecrisUT commented Nov 9, 2024 •
edited
Loading

I think I know why the CI is failing and I'm internally happy about this (they are pushing people to actually modernize the CMake), although people might not catch on to this until it's in Ubuntu LTS. I'll make a PR to unblock the CIs.

Edit: ah I was excited for nothing, this is only because of our CI setup

spglib/cmake/CMakePresets-CI.json

Lines 36 to 38 in 0c1fca6

"errors": {
"deprecated": true
}

Anyway this is resolved in #535

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (35c6693) to head (ea17764).
Report is 50 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #534   +/-   ##
========================================
  Coverage    84.24%   84.24%           
========================================
  Files           26       26           
  Lines         8209     8209           
  Branches      1702     1697    -5     
========================================
  Hits          6916     6916           
  Misses        1293     1293
Flag Coverage Δ
c_api 75.52% <ø> (ø)
fortran_api 56.43% <ø> (ø)
python_api 81.56% <ø> (ø)
unit_tests 13.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo
Copy link
Copy Markdown
Collaborator Author

atztogo commented Nov 9, 2024

What is sphinx-linkcheck?

(           index: line   32) broken    https://onlinelibrary.wiley.com/iucr/doi/10.1107/S2053273323005016 - 403 Client Error: Forbidden for url: https://onlinelibrary.wiley.com/iucr/doi/10.1107/S2053273323005016
(       interface: line   10) ok        https://github.com/spglib/spglib/tree/develop/fortran/spglib_f08.F90
(           index: line   58) ok        https://spglib.readthedocs.io/
(           index: line   28) broken    https://www.tandfonline.com/doi/full/10.1080/27660400.2024.2384822 - 403 Client Error: Forbidden for url: https://www.tandfonline.com/doi/full/10.1080/27660400.2024.2384822

@atztogo
Copy link
Copy Markdown
Collaborator Author

atztogo commented Nov 9, 2024

Still this fails.

(           index: line   28) broken    https://doi.org/10.1080/27660400.2024.2384822 - 403 Client Error: Forbidden for url: https://www.tandfonline.com/doi/full/10.1080/27660400.2024.2384822

@LecrisUT
Copy link
Copy Markdown
Collaborator

LecrisUT commented Nov 9, 2024

sphinx-linkcheck checks that a URL is accessible without being redirected elsewhere. It is setup such that the doi links are allowed to be redirected and those should be preferred. Why it gives a 403, I would need to try it out locally, but I have a clue: sphinx-doc/sphinx#10343 (comment)

Adding it to linkcheck_ignore is good for now though

@atztogo atztogo merged commit 8a968e4 into spglib:develop Nov 10, 2024
@atztogo atztogo deleted the update-ref-spglib branch November 10, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan496 lan496 lan496 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atztogo @LecrisUT @lan496