Fix references to outdated master branch#524
Merged
lan496 merged 2 commits intospglib:developfrom Aug 12, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #524 +/- ##
========================================
Coverage 84.12% 84.12%
========================================
Files 26 26
Lines 8122 8122
Branches 1702 1702
========================================
Hits 6833 6833
Misses 1289 1289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LecrisUT
requested review from
atztogo and
lan496
and removed request for
atztogo
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After removing the outdated branches following #512 (comment), there apparently were links that pointed to outdated files. This PR fixes this issue and introduces the roles to simplify the linkage.
Currently the
linkcheckwill fail on PRs since the links topathpoint statically todevelopbranch. I will probably adapt a similar fix that I have investigated intmt, where the link construction points tobranch/tag/commit, whichever it manages to detect first.