Fix DictInterface deprecation warning missing f-string#511
Merged
LecrisUT merged 1 commit intospglib:developfrom Jul 14, 2024
janosh:fix-dict-interface-depr-warning
Merged
Fix DictInterface deprecation warning missing f-string#511LecrisUT merged 1 commit intospglib:developfrom janosh:fix-dict-interface-depr-warning
DictInterface deprecation warning missing f-string#511LecrisUT merged 1 commit intospglib:developfrom
janosh:fix-dict-interface-depr-warning
Conversation
Collaborator
|
Good catch. I guess at least it had the intended consequence of announcing the depreciation :D |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #511 +/- ##
========================================
Coverage 83.90% 83.90%
========================================
Files 25 25
Lines 8185 8185
Branches 1704 1705 +1
========================================
Hits 6868 6868
Misses 1317 1317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LecrisUT
approved these changes
Jul 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.