Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #507 +/- ##
========================================
Coverage 83.90% 83.90%
========================================
Files 25 25
Lines 8185 8185
Branches 1705 1709 +4
========================================
Hits 6868 6868
Misses 1317 1317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Oh, no this one still doesn't fix the issue 😟. I'll make an issue upstream |
7915b3e to
febe453
Compare
Signed-off-by: Cristian Le <[email protected]>
- Make sure auditwheel is run Signed-off-by: Cristian Le <[email protected]>
febe453 to
0eb811b
Compare
|
Ok this should fix the issue. Just as a sanity check, when For the release, you can either force push another |
|
Thanks for the quick fix! I'll force-push another |
|
Reworked a lot of the CMake build - Python bindings installation outside of `scikit-build-core` is no longer supported. Avoids dangling files that cannot be removed due to lacking python package metadata files (`spglib.dist-info`) - Reworked the detection of when the bundled project needs to be included: - Check for Target `Spglib::symspg` (more robust than checking for any cache variables) - Use `find_package` to check for system installed `Spglib` - Use [`CMAKE_DISABLE_FIND_PACKAGE_Spglib=ON`](https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html) to make sure the bundled version is used - Use [`CMAKE_REQUIRE_FIND_PACKAGE_Spglib=ON`](https://cmake.org/cmake/help/latest/variable/CMAKE_REQUIRE_FIND_PACKAGE_PackageName.html) to make sure a system version is used - If `find_package` failed (and `CMAKE_REQUIRE_FIND_PACKAGE_Spglib` was not set), use the bundled sources - Removed the dynamic loading of the `spglib` C library, `libsymspg` must be resolved at build time - Added `INSTALL_RPATH` for the python `_spglib` library pointing to `$ORIGIN/${CMAKE_INSTALL_LIBDIR}`. *If* you want to use a system installed library, there *must not* be a `libsysmspg` library there - Reverted the `cibuildweel` workaround from #507 Depends-on: #458 Closes #510 Closes #462
cibuildwheelauditwheelis run. Apparently the wheel tags generated byscikit-build-corewere not meant to havemanylinux, insteadauditwheelmust be used to re-link to check and relink to appropriate libcauditwheelinci-buildwheel#510