feat(python): Add type-checking derecated#499
Merged
LecrisUT merged 7 commits intospglib:developfrom Jan 30, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #499 +/- ##
========================================
Coverage 73.30% 73.30%
========================================
Files 26 26
Lines 8068 8068
Branches 1691 1692 +1
========================================
Hits 5914 5914
Misses 1627 1627
Partials 527 527
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
LecrisUT
force-pushed
the
feat/deprecated
branch
2 times, most recently
from
e866a9f to
ce8293f
Compare
LecrisUT
commented
Jan 20, 2025
LecrisUT
force-pushed
the
feat/deprecated
branch
from
41a9f06 to
a826b6d
Compare
lan496
approved these changes
Jan 21, 2025
atztogo
approved these changes
Jan 21, 2025
LecrisUT
force-pushed
the
feat/deprecated
branch
2 times, most recently
from
5a8bd83 to
d1353fe
Compare
Member
|
A lot of tests start failing. Some files look to be missing 🤔 |
Collaborator
Author
|
Yeah, fallout from #527 discussions. Will fix it there and rebase this after |
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
- Added `spglib._spglib.pyi` stump file - Configured mypy more strictly, except for tests - Added missing mypy user annotation - Added missing py.typed Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
- Replace patch file with more robust `tomcli` patch - Simplify bcond statement Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
feat/deprecated
branch
from
7791673 to
334d468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP702 introduced
warnings.deprecatedwith back-ports totyping-extensions. This decorator works for both type-checking and runtime. It can even work with@overloadbut that may require aspglib.pyito keep it clean.