Skip to content

chore: Fix links#497

Merged
lan496 merged 2 commits intospglib:developfrom
LecrisUT:fix/links
Jun 25, 2024
Merged

chore: Fix links#497
lan496 merged 2 commits intospglib:developfrom
LecrisUT:fix/links

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

Fixing a recent broken link. Surprised it did not popup 3 months ago when the website was updated

LecrisUT added 2 commits June 25, 2024 10:35
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (e4addfa) to head (0a07bfe).
Report is 45 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #497   +/-   ##
========================================
  Coverage    83.90%   83.90%           
========================================
  Files           25       25           
  Lines         8184     8184           
  Branches      1709     1705    -4     
========================================
  Hits          6867     6867           
  Misses        1317     1317           
Flag Coverage Δ
c_api 74.78% <ø> (ø)
fortran_api 56.19% <ø> (ø)
python_api 80.35% <ø> (ø)
unit_tests 13.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lan496 lan496 merged commit 9acbe6d into spglib:develop Jun 25, 2024
@LecrisUT LecrisUT deleted the fix/links branch June 25, 2024 09:39
@LecrisUT LecrisUT linked an issue Aug 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linckcheck is too thorough

2 participants