Skip to content

Fix potential SEGV in iterative_search_hall_number#484

Merged
lan496 merged 1 commit intospglib:developfrom
lan496:fix-optional-sym-reduced
May 6, 2024
Merged

Fix potential SEGV in iterative_search_hall_number#484
lan496 merged 1 commit intospglib:developfrom
lan496:fix-optional-sym-reduced

Conversation

@lan496
Copy link
Copy Markdown
Member

@lan496 lan496 commented May 5, 2024

Closes #483

@codecov
Copy link
Copy Markdown

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (69da2b8) to head (bd2c136).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #484   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           25       25           
  Lines         8164     8164           
  Branches      1697     1702    +5     
========================================
  Hits          6842     6842           
  Misses        1322     1322           
Flag Coverage Δ
c_api 74.71% <100.00%> (ø)
fortran_api 56.20% <0.00%> (ø)
python_api 80.03% <0.00%> (-0.02%) ⬇️
unit_tests 13.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 marked this pull request as ready for review May 6, 2024 00:07
@lan496 lan496 requested a review from LecrisUT May 6, 2024 00:07
@lan496 lan496 merged commit d0e8018 into spglib:develop May 6, 2024
@lan496 lan496 deleted the fix-optional-sym-reduced branch May 6, 2024 07:54
@LecrisUT LecrisUT added this to the 2.5 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation fault if sym_reduce_operation() fails

2 participants