Check if primitive symmetry search is passed#479
Merged
lan496 merged 5 commits intospglib:developfrom May 6, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #479 +/- ##
===========================================
+ Coverage 83.80% 83.87% +0.06%
===========================================
Files 25 25
Lines 8164 8167 +3
Branches 1697 1706 +9
===========================================
+ Hits 6842 6850 +8
+ Misses 1322 1317 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LecrisUT
requested changes
May 5, 2024
Co-authored-by: Cristian Le <[email protected]>
LecrisUT
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prm_get_primitive_symmetryseems to be failed with some symprec and the current MSG implementation cannot recover from it. This PR fixes to check the returned primitive symmetry to avoid SEGV.