Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #466 +/- ##
========================================
Coverage 73.30% 73.30%
========================================
Files 26 26
Lines 8068 8068
Branches 1691 1696 +5
========================================
Hits 5914 5914
Misses 1627 1627
Partials 527 527
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LecrisUT
commented
May 13, 2024
1354c96 to
9d7c37d
Compare
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
9d7c37d to
dd8f3b5
Compare
Signed-off-by: Cristian Le <[email protected]>
dd8f3b5 to
54d44cd
Compare
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Collaborator
Author
Signed-off-by: Cristian Le <[email protected]>
Member
|
Where |
Collaborator
Author
That will be a setting in # Do not build spglib C library on documentation builders
[[tool.scikit-build.overrides]]
if.any.env.READTHEDOCS = true
if.any.env.BUILD_DOCS = true
wheel.cmake = falseIf you add that it already works, but the sphinx builder will fail at build step. I'll see if this is a feature that would be added to Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to revisit #420
In principle we can use
autodoc_type_aliasesto simplify the documentation