Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #447 +/- ##
========================================
Coverage 83.59% 83.59%
========================================
Files 24 24
Lines 8118 8118
Branches 1688 1693 +5
========================================
Hits 6786 6786
Misses 1332 1332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It should be used only with CMake >= 3.27 Signed-off-by: Cristian Le <[email protected]>
lan496
approved these changes
Feb 26, 2024
Member
lan496
left a comment
lan496
left a comment
There was a problem hiding this comment.
I've also checked to configure with cmake<3.27 in my local environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator expression used was only for 3.27.
Reproduced the error in: https://github.com/spglib/spglib/actions/runs/8045683520
Confirming the fix in: https://github.com/spglib/spglib/actions/runs/8045769170
Hot-fix: #437
Closes #444