Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #438 +/- ##
========================================
Coverage 83.59% 83.59%
========================================
Files 24 24
Lines 8118 8118
Branches 1686 1689 +3
========================================
Hits 6786 6786
Misses 1332 1332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
West const style is ambiguous, e.g. const pointer. https://hackingcpp.com/cpp/design/east_vs_west_const.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html#qualifieralignment Signed-off-by: Cristian Le <[email protected]>
Improve readability https://clang.llvm.org/docs/ClangFormatStyleOptions.html#indentppdirectives Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
feat/style
branch
2 times, most recently
from
752ad42 to
a6d7a6e
Compare
LecrisUT
requested review from
atztogo and
lan496
and removed request for
atztogo
atztogo
approved these changes
Feb 28, 2024
lan496
approved these changes
Feb 29, 2024
Collaborator
Author
|
/packit build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few styles that we should change:
west const->east const. The latter is always consistent, e.g. take the case of const pointer in the link.west const: the thing on the left is always const.east constbreaks the rule there.See the links in the commit message for alternatives.
Probably worth re-visiting some of the styles with this PR.