Skip to content

ci: Test CMake version#431

Merged
lan496 merged 5 commits intospglib:developfrom
LecrisUT:ci/cmake-version
Apr 1, 2024
Merged

ci: Test CMake version#431
lan496 merged 5 commits intospglib:developfrom
LecrisUT:ci/cmake-version

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Feb 12, 2024 •
edited
Loading

Adds tests for CMake verisons:

  • Minimum supported version
  • Lastest stable version
  • Upcoming release candidate

@LecrisUT LecrisUT changed the title ci: Cover CMake versions ci: Test CMake version Feb 12, 2024
@LecrisUT LecrisUT self-assigned this Feb 12, 2024
@LecrisUT LecrisUT added this to the 2.4 milestone Feb 12, 2024
@LecrisUT LecrisUT force-pushed the ci/cmake-version branch 5 times, most recently from 0a699b1 to 1430023 Compare February 13, 2024 09:03
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.59%. Comparing base (cfe425c) to head (b8eb63b).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #431   +/-   ##
========================================
  Coverage    83.59%   83.59%           
========================================
  Files           24       24           
  Lines         8118     8118           
  Branches      1686     1686           
========================================
  Hits          6786     6786           
  Misses        1332     1332
Flag Coverage Δ
c_api 74.43% <ø> (ø)
fortran_api 56.16% <ø> (ø)
python_api 79.70% <ø> (ø)
unit_tests 13.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT modified the milestones: 2.4, 2.5 Feb 15, 2024
@LecrisUT LecrisUT force-pushed the ci/cmake-version branch 2 times, most recently from ea0afc6 to a5406c5 Compare February 15, 2024 14:30
@LecrisUT LecrisUT mentioned this pull request Feb 25, 2024
Closed
@LecrisUT LecrisUT force-pushed the ci/cmake-version branch 7 times, most recently from 5a9316c to b8eb63b Compare February 29, 2024 10:53
@LecrisUT LecrisUT marked this pull request as ready for review February 29, 2024 11:10
@LecrisUT LecrisUT removed their assignment Feb 29, 2024
@lan496
Copy link
Copy Markdown
Member

lan496 commented Mar 2, 2024

The minimum required CMake version (3.25) looks too recent: for example, ubuntu 22.04 LTS installs 3.22 by default.

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Mar 2, 2024

Yeah, I'm holding off a bit until Ubuntu `24.04. Debian 12 already has 3.25, and hopefully EPEL-next-9 covers RHEL based ones soon.

LecrisUT added 3 commits March 27, 2024 15:15
@LecrisUT
Cover different CMake versions
8d93a38 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Fix leftover CMake 3.20 todo
1cc6f2d 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Fix CMake 3.29 issue
d1fc34a 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT LecrisUT modified the milestones: 2.5, 2.4 Mar 27, 2024
@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Mar 27, 2024

CI in #457 is suffering because of CMake 3.29 failure. I will try to focus on this one a bit and at least port some basic compatibility for 3.20

@LecrisUT LecrisUT mentioned this pull request Mar 27, 2024
Closed
5 tasks
@LecrisUT
CMake 3.24: Fix FetchContent
8eac609 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT LecrisUT requested a review from lan496 March 27, 2024 14:48
@LecrisUT LecrisUT mentioned this pull request Mar 27, 2024
Merged
7 tasks
@LecrisUT
Use Spglib_SOURCE_DIR to detect if project was defined
851be97 
Using `Spglib_IS_TOP_LEVEL` does not work when in a chain of FetchContent

Signed-off-by: Cristian Le <[email protected]>
@LecrisUT LecrisUT mentioned this pull request Mar 27, 2024
Merged
@LecrisUT LecrisUT linked an issue Mar 27, 2024 that may be closed by this pull request
Compillation error in HPC #456
Closed
@LecrisUT LecrisUT mentioned this pull request Mar 27, 2024
Merged
4 tasks
lan496
lan496 reviewed Mar 31, 2024
View reviewed changes
.github/workflows/step_test.yaml
strategy:
fail-fast: false
matrix:
cmake: [ "3.20", "latest", "latestrc" ]
Copy link
Copy Markdown
Member

@lan496 lan496 Mar 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for me: this is minimum required CMake version

lan496
lan496 reviewed Mar 31, 2024
View reviewed changes
@lan496 lan496 merged commit 2edad27 into spglib:develop Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan496 lan496 lan496 left review comments

Assignees

@lan496 lan496

Labels

None yet

Projects

Spglib developers' kanban
Status: ✅ Done

Milestone

2.4

Development

Successfully merging this pull request may close these issues.

Compillation error in HPC

2 participants

@LecrisUT @lan496