Skip to content

ci: Update codecov to v4#425

Merged
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:ci/codecov
Feb 12, 2024
Merged

ci: Update codecov to v4#425
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:ci/codecov

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Feb 5, 2024 •
edited
Loading

Closes #417

I've also move the codecov.yaml to .github folder to clean-up the front page a bit. We could to the same with .readthedocs.yaml, Contributing.md, CITATION.cff, .mdformat.toml (this one just add it to .pre-commit-config.yaml)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6d3d3f) 83.71% compared to head (cb49d90) 71.69%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop     #425       +/-   ##
============================================
- Coverage    83.71%   71.69%   -12.03%     
============================================
  Files           24       51       +27     
  Lines         8205     9483     +1278     
  Branches         0     1754     +1754     
============================================
- Hits          6869     6799       -70     
- Misses        1336     2683     +1347     
- Partials         0        1        +1
Flag Coverage Δ
c_api 77.39% <ø> (-0.12%) ⬇️
fortran_api 56.18% <ø> (-0.16%) ⬇️
python_api 79.74% <ø> (-0.21%) ⬇️
unit_tests 1.26% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Feb 5, 2024

Interesting, codecov is reporting different results now, e.g. cel_copy_cell is not covered anymore, checking it manually, that is indeed the case. Seems the parser is a bit more robust now

@lan496 lan496 self-requested a review February 5, 2024 22:59
lan496
lan496 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could to the same with .readthedocs.yaml, Contributing.md, CITATION.cff, .mdformat.toml (this one just add it to .pre-commit-config.yaml)

I feel CITATION.cff can be moved to .github/, but let's consider it in another place.

@lan496
Copy link
Copy Markdown
Member

lan496 commented Feb 11, 2024

Let's merge this PR after resolving conflicts in ChangeLog.md

@LecrisUT LecrisUT merged commit cddbfae into spglib:develop Feb 12, 2024
@LecrisUT LecrisUT deleted the ci/codecov branch February 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan496 lan496 lan496 approved these changes

Assignees

@lan496 lan496

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Codecov v4

2 participants

@LecrisUT @lan496