Merged
Conversation
lan496
approved these changes
Feb 5, 2024
LecrisUT
force-pushed
the
fix/DynamicVersion
branch
from
1ecb45a to
c73c7fd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #423 +/- ##
========================================
Coverage 83.71% 83.71%
========================================
Files 24 24
Lines 8205 8205
========================================
Hits 6869 6869
Misses 1336 1336
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes compilation when git repository does not have tag Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
fix/DynamicVersion
branch
from
c73c7fd to
172b34c
Compare
Collaborator
Author
|
/packit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CMake project when git repository does not have tag (e.g. on forks): LecrisUT/CMakeExtraUtils#34