Skip to content

Release v2.3.0#404

Merged
lan496 merged 1 commit intospglib:developfrom
lan496:release-v2.3.0
Jan 27, 2024
Merged

Release v2.3.0#404
lan496 merged 1 commit intospglib:developfrom
lan496:release-v2.3.0

Conversation

@lan496
Copy link
Copy Markdown
Member

@lan496 lan496 commented Jan 27, 2024

Closes #384

After this PR is merged, I'll put v2.3.0-rc1 tag to the commit first. Then v2.3.0 tag.

List of merged PRs were generated by

gh pr list --state merged --search "merged:>2023-12-07" --json url,title,number | jq -r '.[] | "[[#\(.number)]](\(.url)) - \(.title)"'

@lan496 lan496 requested review from LecrisUT and atztogo January 27, 2024 03:28
@lan496 lan496 added this to the 2.3 milestone Jan 27, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (504164b) 83.71% compared to head (76af0b8) 83.71%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #404   +/-   ##
========================================
  Coverage    83.71%   83.71%           
========================================
  Files           24       24           
  Lines         8205     8205           
========================================
  Hits          6869     6869           
  Misses        1336     1336
Flag Coverage Δ
c_api 77.50% <ø> (ø)
fortran_api 56.33% <ø> (ø)
python_api 79.94% <ø> (ø)
unit_tests 1.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LecrisUT
LecrisUT approved these changes Jan 27, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was just confirming that rc tags are working: https://github.com/LecrisUT/spglib/actions/runs/7676699614

atztogo
atztogo approved these changes Jan 27, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lan496 lan496 merged commit 199d970 into spglib:develop Jan 27, 2024
@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Jan 27, 2024

Let me try TestPyPI for practice.

gco develop
git pull upstream develop  
git tag v2.3.0-rc1 
git push upstream v2.3.0-rc1

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Jan 27, 2024

successfully uploaded to TestPyPI
https://test.pypi.org/project/spglib/2.3.0rc1/

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Jan 27, 2024 

git tag v2.3.0
git push upstream v2.3.0

@LecrisUT
Copy link
Copy Markdown
Collaborator

LecrisUT commented Jan 27, 2024

🤔 never tested with 2 tags on same commit

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Jan 27, 2024

It is rather my practice for the current CI 😌

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Jan 27, 2024

v2.3.0 is released!
https://pypi.org/project/spglib/2.3.0/

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Jan 27, 2024

Release note on GitHub
https://github.com/spglib/spglib/releases/tag/v2.3.0

@lan496 lan496 deleted the release-v2.3.0 branch January 27, 2024 12:04
@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Jan 27, 2024

The latest docs still point to v2.1.1.****?
https://spglib.readthedocs.io/en/latest/#
image

@LecrisUT
Copy link
Copy Markdown
Collaborator

LecrisUT commented Jan 27, 2024

Indeed, but stable points to the new tag. Maybe we can rename stable to latest and latest to develop, wdyt?

@lan496 lan496 mentioned this pull request Jan 27, 2024
Closed
@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Jan 27, 2024

I've opened an issue for this.
#406

@chenrui333 chenrui333 mentioned this pull request Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atztogo atztogo atztogo approved these changes

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

Releasing v2.3.0

3 participants

@lan496 @LecrisUT @atztogo