feat: Reorganize Fortran interface#396
Merged
LecrisUT merged 1 commit intospglib:developfrom Jan 20, 2024
Merged
Conversation
Member
|
I would defer the Fortran interface on @atztogo . |
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
feat/fortran-organize
branch
from
2d3ab23 to
bb3eb2d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #396 +/- ##
===========================================
- Coverage 83.86% 83.85% -0.02%
===========================================
Files 24 24
Lines 8180 8181 +1
===========================================
Hits 6860 6860
- Misses 1320 1321 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick PR to re-organize the fortran api to be more legible and extendable. I am also considering splitting it into a header-source file, but at the moment there is little gain since CMake does not support bundling these files like with cxx-modules.