Skip to content

ci: Enable testing for Fedora 38#393

Merged
LecrisUT merged 1 commit intospglib:developfrom
LecrisUT:fedora/enable-all
Jan 20, 2024
Merged

ci: Enable testing for Fedora 38#393
LecrisUT merged 1 commit intospglib:developfrom
LecrisUT:fedora/enable-all

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

Depends on #356

@LecrisUT LecrisUT marked this pull request as draft January 18, 2024 10:50
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f855378) 83.86% compared to head (29156d0) 83.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #393   +/-   ##
========================================
  Coverage    83.86%   83.86%           
========================================
  Files           24       24           
  Lines         8180     8180           
========================================
  Hits          6860     6860           
  Misses        1320     1320           
Flag Coverage Δ
c_api 77.59% <ø> (ø)
fortran_api 56.15% <ø> (ø)
python_api 80.38% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT marked this pull request as ready for review January 19, 2024 17:56
@lan496 lan496 self-requested a review January 20, 2024 00:19
@lan496
Copy link
Copy Markdown
Member

lan496 commented Jan 20, 2024

Ping me after rebasing #356

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

Rebased, if everything is fine, can add testing-farm 38 to the branch protect

@lan496
Copy link
Copy Markdown
Member

lan496 commented Jan 20, 2024

Sure. I've added "testing-farm:fedora-38-x86_64" and "testing-farm:fedora-38-aarch64".

@LecrisUT LecrisUT enabled auto-merge (rebase) January 20, 2024 00:37
@LecrisUT LecrisUT merged commit c9e6c81 into spglib:develop Jan 20, 2024
@lan496 lan496 removed their request for review January 20, 2024 00:45
@lan496 lan496 mentioned this pull request Jan 20, 2024
4 tasks
@LecrisUT LecrisUT deleted the fedora/enable-all branch January 22, 2024 09:38
@lan496 lan496 added this to the 2.3 milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants