Skip to content

Drop ASE Atoms-style input#386

Merged
lan496 merged 1 commit intospglib:developfrom
lan496:drop-ase
Jan 2, 2024
Merged

Drop ASE Atoms-style input#386
lan496 merged 1 commit intospglib:developfrom
lan496:drop-ase

Conversation

@lan496
Copy link
Copy Markdown
Member

@lan496 lan496 commented Jan 2, 2024

Closes #385

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04d097d) 83.84% compared to head (a5a94e2) 83.84%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #386   +/-   ##
========================================
  Coverage    83.84%   83.84%           
========================================
  Files           24       24           
  Lines         8172     8172           
========================================
  Hits          6852     6852           
  Misses        1320     1320           
Flag Coverage Δ
c_api 77.57% <ø> (ø)
fortran_api 56.21% <ø> (ø)
python_api 80.48% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 requested a review from atztogo January 2, 2024 01:46
Copy link
Copy Markdown
Collaborator

@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lan496!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop ASE Atoms-like input for Python interface

4 participants