Conversation
This reverts commit 16a1efd.
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #375 +/- ##
========================================
Coverage 83.80% 83.80%
========================================
Files 24 24
Lines 8167 8167
========================================
Hits 6844 6844
Misses 1323 1323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| pre_build: | ||
| - echo "Placeholder for doxygen builds via cmake" | ||
| post_create_environment: | ||
| - pip install --pre --upgrade sphinx-book-theme |
There was a problem hiding this comment.
If I understand correctly, this line installs sphinx-book-theme==v1.1.0rc1 (sphinx-7 is supported), right?
There was a problem hiding this comment.
Yes, here is the build. Basically we do not have a pin for the sphinx-book-theme, so when RTD detects that sphinx-book-theme was already installed (right after the environment was created), it uses that one. The --pre ensures we are pricking up rc releases (Also a reason why I would prefer on the spglib side to always upload to PyPI instead of https://test.pypi.org/legacy/)
lan496
left a comment
lan496
left a comment
There was a problem hiding this comment.
LGTM. What else needs to be done for v2.2.0?
Nothing more really. Downstream conda has some issues on |
3 participants
For now we have a temporary commit 08cc242 to use the pre-release version of sphinx-book-theme