Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #358 +/- ##
===========================================
+ Coverage 83.56% 83.68% +0.12%
===========================================
Files 24 24
Lines 8157 8144 -13
===========================================
- Hits 6816 6815 -1
+ Misses 1341 1329 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
@lan496 Can you mark Here's an example of where to find the settings: |
The CIs are failing on the `windows-latest` due to the address-sanitizer. Maybe it requires additional static linkage flags. Needs to be investigated
LecrisUT
force-pushed
the
fix/windows-ci
branch
from
6f1f1d8 to
53132bb
Compare
Merged
Member
|
@LecrisUT Done. |
Collaborator
Author
|
Great thank you. I will merge this one so we can unlock the other PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.