Merged
Conversation
9450bcf to
3ee38d1
Compare
Collaborator
Author
|
I will write proper tests for this when I address #363 |
lan496
approved these changes
Dec 2, 2023
Signed-off-by: Cristian Le <[email protected]>
3ee38d1 to
2a1798a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #357 +/- ##
========================================
Coverage 83.80% 83.80%
========================================
Files 24 24
Lines 8167 8167
========================================
Hits 6844 6844
Misses 1323 1323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this when working on an old debian container. Apparently
dependsis not the correct syntax it should beRequires. Surprised these were not picked up by the tmt tests