Skip to content

fix: Fortran pkg-config file#357

Merged
lan496 merged 1 commit intospglib:developfrom
LecrisUT:fix/fortran-pkgconf
Dec 2, 2023
Merged

fix: Fortran pkg-config file#357
lan496 merged 1 commit intospglib:developfrom
LecrisUT:fix/fortran-pkgconf

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Nov 9, 2023

Found this when working on an old debian container. Apparently depends is not the correct syntax it should be Requires. Surprised these were not picked up by the tmt tests

@LecrisUT LecrisUT force-pushed the fix/fortran-pkgconf branch from 9450bcf to 3ee38d1 Compare November 14, 2023 09:56
@LecrisUT LecrisUT mentioned this pull request Nov 14, 2023
2 tasks
@LecrisUT LecrisUT requested a review from lan496 November 14, 2023 10:21
@LecrisUT LecrisUT added the bug label Nov 14, 2023
@LecrisUT
Copy link
Copy Markdown
Collaborator Author

I will write proper tests for this when I address #363

@lan496 lan496 force-pushed the fix/fortran-pkgconf branch from 3ee38d1 to 2a1798a Compare December 2, 2023 12:57
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b02dedb) 83.80% compared to head (2a1798a) 83.80%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #357   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           24       24           
  Lines         8167     8167           
========================================
  Hits          6844     6844           
  Misses        1323     1323           
Flag Coverage Δ
c_api 77.18% <ø> (ø)
fortran_api 56.19% <ø> (ø)
python_api 80.47% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 merged commit 9c1099c into spglib:develop Dec 2, 2023
@LecrisUT LecrisUT deleted the fix/fortran-pkgconf branch December 8, 2023 10:38
@LecrisUT LecrisUT added this to the 2.2 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants