Tests for noncollinear case and spg_get_symmetry_with_site_tensors of fortran interface#342
Merged
atztogo merged 5 commits intospglib:developfrom Oct 11, 2023
atztogo:test-noncollinear
Merged
Tests for noncollinear case and spg_get_symmetry_with_site_tensors of fortran interface#342atztogo merged 5 commits intospglib:developfrom atztogo:test-noncollinear
atztogo merged 5 commits intospglib:developfrom
atztogo:test-noncollinear
Conversation
atztogo
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #342 +/- ##
===========================================
+ Coverage 83.53% 83.56% +0.02%
===========================================
Files 24 24
Lines 8157 8157
===========================================
+ Hits 6814 6816 +2
+ Misses 1343 1341 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LecrisUT
reviewed
Oct 3, 2023
Member
|
How about adding the explanation of the max_size also in the documents? |
Collaborator
Author
I agree, #345. Will be done in a different PR. |
Co-authored-by: Cristian Le <[email protected]>
LecrisUT
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more tests of Fortran interface: