Skip to content

fix: Julia packaging issues#341

Merged
lan496 merged 3 commits intospglib:developfrom
LecrisUT:fix/gtest
Dec 4, 2023
Merged

fix: Julia packaging issues#341
lan496 merged 3 commits intospglib:developfrom
LecrisUT:fix/gtest

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Oct 2, 2023 •
edited
Loading

Trying to fix JuliaPackaging/Yggdrasil#7310, and do a bit of cleanup.

  • Added missing include(GoogleTest). It is surprising that this issue was not picked up by any other CI/downstream
  • Moved compilation warnings to only CI. Downstream is getting bombarded with warnings that are slow to fix and it makes it hard to debug on their side.
  • _Thread_local is not detected in Julia's packaging CI compiler issue on their end

@singularitti I will try to make some quick fixes here, but can you create the patches and try them on the Julia side CI?

After this we'll need to cherry-pick this one and add them to release-2.1 hotfix branch

@LecrisUT LecrisUT self-assigned this Oct 2, 2023
@LecrisUT LecrisUT changed the title fix: GoogleTest fix: Julia packaging issues Oct 11, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b02dedb) 83.80% compared to head (de9247c) 83.80%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #341   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           24       24           
  Lines         8167     8167           
========================================
  Hits          6844     6844           
  Misses        1323     1323
Flag Coverage Δ
c_api 77.18% <ø> (ø)
fortran_api 56.19% <ø> (ø)
python_api 80.47% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT mentioned this pull request Oct 28, 2023
Closed
2 tasks
@LecrisUT LecrisUT assigned lan496 and unassigned LecrisUT Oct 30, 2023
@LecrisUT LecrisUT requested a review from lan496 October 30, 2023 09:20
@lan496 lan496 enabled auto-merge December 2, 2023 13:24
@lan496 lan496 merged commit 82c2a22 into spglib:develop Dec 4, 2023
@Porkepix Porkepix mentioned this pull request Dec 8, 2023
Merged
@singularitti singularitti mentioned this pull request Dec 12, 2023
Merged
@singularitti
Copy link
Copy Markdown
Contributor

singularitti commented Dec 12, 2023

Hi @LecrisUT, when you say the "packaging issue is fixed", do you mean the tests can be run? Because I still cannot run these tests when building Spglib artifacts on Julia CI systems.

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Dec 12, 2023

@singularitti Yes, the packaging of Gtest itself should be fixed here, so it should more reliably pick it up. The issue you've encountered in JuliaPackaging/Yggdrasil@189ff1b is that there were no pre-downloaded sources of gtest.

The main issue as downstream put it is to do the tests in an emulated environment. I have an idea (#363) that would be useful for conda as well, where it can run the packaged versions on the real machine. Not sure about Julia CI if it can have a similar feature.

@LecrisUT LecrisUT deleted the fix/gtest branch January 22, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan496 lan496 lan496 approved these changes

Assignees

@lan496 lan496

Labels

None yet

Projects

Spglib developers' kanban
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LecrisUT @codecov-commenter @singularitti @lan496