Add magnetic dataset support in Fortran#333
Merged
atztogo merged 1 commit intospglib:developfrom Sep 20, 2023
atztogo:magdataset
Merged
Add magnetic dataset support in Fortran#333atztogo merged 1 commit intospglib:developfrom atztogo:magdataset
atztogo merged 1 commit intospglib:developfrom
atztogo:magdataset
Conversation
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #333 +/- ##
===========================================
- Coverage 83.60% 82.99% -0.61%
===========================================
Files 23 24 +1
Lines 7942 8140 +198
===========================================
+ Hits 6640 6756 +116
- Misses 1302 1384 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh PR for the same purpose but instead of #292.
I also added tests for
spg_get_datasetin Fortran.