Skip to content

Release v2.1.0#324

Merged
lan496 merged 1 commit intospglib:developfrom
lan496:release-2.1.0
Sep 10, 2023
Merged

Release v2.1.0#324
lan496 merged 1 commit intospglib:developfrom
lan496:release-2.1.0

Conversation

@lan496
Copy link
Copy Markdown
Member

@lan496 lan496 commented Sep 10, 2023

Close: #239

After this PR is merged, I'll put v2.1.0 tag to the commit.

@lan496 lan496 requested review from LecrisUT and atztogo September 10, 2023 02:33
@lan496 lan496 self-assigned this Sep 10, 2023
@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Sep 10, 2023

Note: I generated the list of PRs by gh command though this task will be automated in future.

gh pr list --state merged --limit 99 --json url,title,number | jq -r '.[] | "[[#\(.number)]](\(.url)) - \(.title)"'

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Sep 10, 2023

What happened on rpm-build CIs?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 10, 2023 •
edited by codecov bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.60%. Comparing base (e0e5c54) to head (6f4dbfb).
⚠️ Report is 503 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #324   +/-   ##
========================================
  Coverage    83.60%   83.60%           
========================================
  Files           23       23           
  Lines         7942     7942           
========================================
  Hits          6640     6640           
  Misses        1302     1302
Flag Coverage Δ
c_api 76.10% <ø> (ø)
fortran_api 36.82% <ø> (ø)
python_api 80.42% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

atztogo
atztogo approved these changes Sep 10, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lan496, thanks for your work. Probably categorising commits requires some effort.

@LecrisUT
Copy link
Copy Markdown
Collaborator

LecrisUT commented Sep 10, 2023 •
edited
Loading

That is weird, aarch64 are failing due to the build system infrastructure, I'll ask around what is going on.

Last build was successful so you can go ahed with this one. (On the fedora downstream side, there is a different infrastructure)

@lan496 lan496 merged commit 59bea8a into spglib:develop Sep 10, 2023
@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Sep 10, 2023

I've pushed v2.1.0 tag to upstream.

git checkout develop
git pull upstream develop
git tag v2.1.0
git push upstream v2.1.0

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Sep 10, 2023

https://github.com/spglib/spglib/actions/runs/6135805202/job/16650183543
Configuration for Trusted Publisher seems to be incorrect.

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Sep 10, 2023

Rerun the failed pypi publish after fixing Trusted Publisher Management in PyPI and TestPyPI (fix to rename release.yml to release.yaml).

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Sep 10, 2023

spglib v2.1.0 is published in PyPI 🎉
https://pypi.org/project/spglib/

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Sep 10, 2023

GitHub's release is nicely generated: https://github.com/spglib/spglib/releases/tag/untagged-6db672e52eb611e6598b

@LecrisUT
Copy link
Copy Markdown
Collaborator

LecrisUT commented Sep 10, 2023

@lan496 please convert draft releases to proper releases after you reviewed it

@lan496
Copy link
Copy Markdown
Member Author

lan496 commented Sep 10, 2023

@LecrisUT Thanks. I've converted. I didn't know that a draft is not seen by the public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atztogo atztogo atztogo approved these changes

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees

@lan496 lan496

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Version 2.1

4 participants

@lan496 @codecov-commenter @LecrisUT @atztogo