Merged
Conversation
lan496
approved these changes
Jul 15, 2023
Member
lan496
left a comment
lan496
left a comment
There was a problem hiding this comment.
Sorry, I missed this PR. LGTM!
atztogo
approved these changes
Jul 15, 2023
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
cmake/pytest
branch
5 times, most recently
from
1277e66 to
6b2595c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #309 +/- ##
===========================================
+ Coverage 83.64% 83.66% +0.01%
===========================================
Files 23 23
Lines 6274 6274
===========================================
+ Hits 5248 5249 +1
+ Misses 1026 1025 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Cristian Le <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, this one should help immensely for debugging. I don't know if you had a similar issue on VSCode, but for me on CLion, I couldn't get the debugger to run when I was running
pytestbecause clion would not add the gdb debugger to that. Well, this one solves it by adding the pytest runner directly to cmake.Here is my
CMakeUserPresets.jsonthat I useCMakeUserPresets.json
{ "version": 6, "configurePresets": [ { "name": "python", "displayName": "With python preset", "binaryDir": "cmake-build-python", "inherits": ["default"], "cacheVariables": { "CMAKE_BUILD_TYPE": { "type": "STRING", "value": "Debug" }, "SPGLIB_WITH_Python": { "type": "BOOL", "value": true }, "CMAKE_INSTALL_PREFIX": { "type": "FILEPATH", "value": "install" } }, "vendor": { "jetbrains.com/clion": { "toolchain": "spglib" } } } ], "buildPresets": [ { "name": "python", "displayName": "With python preset", "configurePreset": "python" } ], "testPresets": [ { "name": "python", "displayName": "With python preset", "configurePreset": "python", "filter": { "include": { "name": "python-tests" } } } ], "workflowPresets": [ { "name": "python", "displayName": "Python workflow", "steps": [ { "type": "configure", "name": "python" }, { "type": "build", "name": "python" }, { "type": "test", "name": "python" } ] } ] }It includes my clion configuration, but that can be exported for others to have an easy way of setting up their environment. There should also be an equivalent vscode approach for this.