feat: Switch to importlib.resources#308
Merged
lan496 merged 3 commits intospglib:developfrom Feb 16, 2024
Merged
Conversation
LecrisUT
changed the title
importlib.resourcesimportlib.resources
LecrisUT
force-pushed
the
importlib
branch
2 times, most recently
from
9acd14d to
9a5e44b
Compare
LecrisUT
changed the title
importlib.resourcesimportlib.resources
LecrisUT
force-pushed
the
importlib
branch
2 times, most recently
from
9d1cc7d to
0052f64
Compare
Collaborator
Author
|
Scratch that it is still failing in pytest. Will investigate |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #308 +/- ##
========================================
Coverage 83.59% 83.59%
========================================
Files 24 24
Lines 8119 8119
Branches 1694 1687 -7
========================================
Hits 6787 6787
Misses 1332 1332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LecrisUT
force-pushed
the
importlib
branch
2 times, most recently
from
a6ba623 to
011af03
Compare
5 tasks
Member
|
OK, let's follow the order: #397 -> #335 -> #308 |
Collaborator
Author
|
Ok, I've added the comments for the changelog for this trio and all is ready for final review |
LecrisUT
force-pushed
the
importlib
branch
2 times, most recently
from
d0ac510 to
fe76ba5
Compare
Member
|
@LecrisUT Can you resolve conflicts? |
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Collaborator
Author
|
Ok, resolved, I'll let you check one more time the changes. |
lan496
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In principle this should allow us to use
pip install -e .and be able to debug more easily. But this requires upstreamscikit-build-coreto add an implementation:importlib.resourcesin edittable installs scikit-build/scikit-build-core#399Depends on: #335