Skip to content

Set C standard to C11#304

Merged
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:C-standard
Jun 20, 2023
Merged

Set C standard to C11#304
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:C-standard

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Jun 19, 2023 •
edited
Loading

TODO:

  • Documentation

@LecrisUT LecrisUT requested review from atztogo and lan496 June 19, 2023 12:13
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 19, 2023 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (4893b4d) to head (20a8ac0).
Report is 370 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #304   +/-   ##
========================================
  Coverage    83.64%   83.64%           
========================================
  Files           23       23           
  Lines         6274     6274           
========================================
  Hits          5248     5248           
  Misses        1026     1026
Flag Coverage Δ
c_api 74.01% <ø> (ø)
fortran_api 36.23% <ø> (ø)
python_api 80.42% <ø> (ø)
unit_tests 74.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo
Copy link
Copy Markdown
Collaborator

atztogo commented Jun 20, 2023

@LecrisUT, are we waiting for windows test by #286?

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Jun 20, 2023

For this one? No it's self-contained and all ready. Just need documentation review.

@atztogo
Copy link
Copy Markdown
Collaborator

atztogo commented Jun 20, 2023

I asked because I have been bitten by windows compilers number of times in old days. So I may be relaxed if I could see this PR passes on windows compilers.

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Jun 20, 2023

I asked because I have been bitten by windows compilers number of times in old days. So I may be relaxed if I could see this PR passes on windows compilers.

Oh in that sense. Sure this one is already a dependency for most of the PRs, #286 included. And indeed for that one the tests are passing (except the flakiness bug that I'm slowly trying to address with #303, #297 and other test improvements)

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Jun 20, 2023

Ok, see #286. Windows tests are passing with the C11 even on pytest 🎉. I have confirmed that the correct compiler is used in https://github.com/spglib/spglib/actions/runs/5319593736

lan496
lan496 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The newer standard will make our lives easier.

@lan496 lan496 assigned LecrisUT and unassigned lan496 Jun 20, 2023
LecrisUT added 2 commits June 20, 2023 13:55
@LecrisUT
Set C standard to C11
a8423f3 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Document minimum C standard
20a8ac0 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Jun 20, 2023

Screenshot_20230620_135849
Hmm, it didn't allow to set an auto-merge, maybe it only has an effect on future PRs.

@LecrisUT LecrisUT merged commit b7abe8d into spglib:develop Jun 20, 2023
@LecrisUT LecrisUT deleted the C-standard branch June 20, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atztogo atztogo atztogo approved these changes

@lan496 lan496 lan496 approved these changes

Assignees

@LecrisUT LecrisUT

Labels

None yet

Projects

Spglib developers' kanban
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LecrisUT @codecov-commenter @atztogo @lan496