ci: Use container with pre-installed toolchains#285
Merged
LecrisUT merged 1 commit intospglib:developfrom Jun 8, 2023
Merged
Conversation
Signed-off-by: Cristian Le <[email protected]>
Collaborator
|
I have no idea about this, and I think it is good if you think it is good. |
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #285 +/- ##
========================================
Coverage 74.21% 74.21%
========================================
Files 22 22
Lines 5588 5588
========================================
Hits 4147 4147
Misses 1441 1441
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
lan496
approved these changes
Jun 8, 2023
LecrisUT
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a container that I am using with pre-installed toolchains (based on nlohmann/json-ci). If you want, we can migrate/copy/fork this to spglib organization for better control of the container os and toolchain versions.
A few things to note: