Fedora packaging maintainence#272
Merged
LecrisUT merged 3 commits intospglib:developfrom May 20, 2023
Merged
Conversation
LecrisUT
force-pushed
the
Fedora/tmt
branch
3 times, most recently
from
290360d to
e38c0dc
Compare
Recommendations from other packagers:
- Avoid excessive name macros
- Double new line between sections
- Use rm to remove things from installation
- Source numbering is unnecessary
- Use %{pyproject_files}
- Postponed: Installing in fortran modules in %{_fmoddir}
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Collaborator
Author
|
/packit build |
lan496
approved these changes
May 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a few comments on other packages about best practices for packaging that I wanted to include here. Also added simple smoke tests for the python package. I will add similar ones for the other bindings.
Depends on: #274 (Intel broke their repository) ✔️