Add rpm spec file by LecrisUT · Pull Request #266 · spglib/spglib

LecrisUT · 2023-03-20T20:10:48Z

To make it easier to maintain Fedora packages (and subsequently any Redhat, Centos, Opensuse, etc.), we should include a spglib.spec file with the supported build instructions. Currently this one is available and tracked at my copr repo. Adding this will help with package maintenance in that:

A relevant copr build will be triggered for:
- commits to main -> New build in lecris/nightly: Users can use this to test the newest version of main (no package update available for users)
- PR -> New build in lecris/spglib: For CI puposes (automatically updates to check newest build
- releases-> New build in lecris/release: Users can use this to get the newest stable releases before they are ported to Fedora
The downstream spec files at src.fedoraproject.org are synchronized with these files (with appropriate version values).
To build locally use packit build in-mock or other alternatives like in-copr (Much simpler than the traditional rpmbuild, rpkg, etc.)

Depends on: #268

codecov-commenter · 2023-03-20T20:23:15Z

Codecov Report

Patch coverage has no change and project coverage change: +11.77 🎉

Comparison is base (bb8c35f) 73.92% compared to head (0a134dc) 85.69%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@             Coverage Diff              @@
##           develop     #266       +/-   ##
============================================
+ Coverage    73.92%   85.69%   +11.77%     
============================================
  Files           22       23        +1     
  Lines         5576     6069      +493     
============================================
+ Hits          4122     5201     +1079     
+ Misses        1454      868      -586

Flag	Coverage Δ
c_api	`73.70% <ø> (ø)`
fortran_api	`37.37% <ø> (ø)`
python_api	`82.84% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pyproject.toml

lan496 · 2023-04-02T04:14:14Z

@LecrisUT Can you separate 7b5f6ff from this PR, or change the title of this PR?

rpm spec file

I do not know the Fedora package sides, so I cannot say any useful comments on this point.

python optional dependencies

I think there is no standard for naming extra dependencies. doc -> docs would be fine, but testing -> test would be more controversial (why not tests?). Anyway, I have no objection to names because you have left aliases.

LecrisUT · 2023-04-02T07:15:35Z

@LecrisUT Can you separate 7b5f6ff from this PR, or change the title of this PR?

Sure, I'll cherry-pick it tomorrow

python optional dependencies

I think there is no standard for naming extra dependencies. doc -> docs would be fine, but testing -> test would be more controversial (why not tests?). Anyway, I have no objection to names because you have left aliases.

I've mostly use scikit-build convention and PEP621. Yeah, there isn't much of a naming guideline, we can just look around our community and follow what other projects we are closely related to.

Signed-off-by: Cristian Le <[email protected]>

lan496

I have also no objection. Thanks!

LecrisUT · 2023-04-04T13:51:09Z

@lan496 I forgot, can you install packit app? https://packit.dev/docs/guide/#1-set-up-packit-integration, oh but it might require fas account for authenthication. Ignore that and I'll ask packit people to manually configure that (it's an upstream issue)

lan496 · 2023-04-04T22:40:35Z

@LecrisUT I've installed it to spglib/spglib. Can you check?

lan496 · 2023-04-04T22:45:44Z

@LecrisUT Can you handle packit/notifications#512?
Or, do I need to set it?

LecrisUT · 2023-04-04T22:46:34Z

I will handle that one, thank you

LecrisUT · 2023-04-05T06:43:55Z

/packit build

packit-as-a-service · 2023-04-05T06:44:08Z

Based on your Packit configuration the settings of the lecris/spglib Copr project would need to be updated as follows:

field	old value	new value
additional_repos	['copr://lecris/scikit-build-core']	['copr://@scikit-build/release']

Packit was unable to update the settings above as it is missing admin permissions on the lecris/spglib Copr project.

To fix this you can do one of the following:

Grant Packit admin permissions on the lecris/spglib Copr project on the permissions page.
Change the above Copr project settings manually on the settings page to match the Packit configuration.
Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

packit-as-a-service · 2023-04-05T06:44:22Z

Based on your Packit configuration the settings of the lecris/spglib Copr project would need to be updated as follows:

field	old value	new value
additional_repos	['copr://lecris/scikit-build-core']	['copr://@scikit-build/release']

Packit was unable to update the settings above as it is missing admin permissions on the lecris/spglib Copr project.

To fix this you can do one of the following:

Grant Packit admin permissions on the lecris/spglib Copr project on the permissions page.
Change the above Copr project settings manually on the settings page to match the Packit configuration.
Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

packit-as-a-service · 2023-04-05T06:44:39Z

Based on your Packit configuration the settings of the lecris/spglib Copr project would need to be updated as follows:

field	old value	new value
additional_repos	['copr://lecris/scikit-build-core']	['copr://@scikit-build/release']

Packit was unable to update the settings above as it is missing admin permissions on the lecris/spglib Copr project.

To fix this you can do one of the following:

Grant Packit admin permissions on the lecris/spglib Copr project on the permissions page.
Change the above Copr project settings manually on the settings page to match the Packit configuration.
Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

LecrisUT · 2023-04-05T06:47:32Z

/packit build

LecrisUT · 2023-04-05T06:58:35Z

Great, it works :). Thnx for the installation @lan496

LecrisUT marked this pull request as draft March 21, 2023 09:23

LecrisUT force-pushed the rpm-spec branch 4 times, most recently from 9230aa2 to 3bd063a Compare March 24, 2023 14:19

LecrisUT force-pushed the rpm-spec branch from 3bd063a to 94bcde7 Compare March 31, 2023 16:36

LecrisUT marked this pull request as ready for review March 31, 2023 16:47

LecrisUT added the enhancement Significant ehancements label Mar 31, 2023

LecrisUT requested review from atztogo and lan496 March 31, 2023 16:48

lan496 reviewed Apr 2, 2023

View reviewed changes

pyproject.toml Show resolved Hide resolved

atztogo approved these changes Apr 2, 2023

View reviewed changes

LecrisUT added 2 commits April 4, 2023 13:33

Add rpm spec file

11ad8d8

Signed-off-by: Cristian Le <[email protected]>

Initialize packit workflow

0a134dc

Signed-off-by: Cristian Le <[email protected]>

LecrisUT force-pushed the rpm-spec branch from 94bcde7 to 0a134dc Compare April 4, 2023 11:33

LecrisUT requested a review from lan496 April 4, 2023 11:35

lan496 approved these changes Apr 4, 2023

View reviewed changes

LecrisUT merged commit 3681a8a into spglib:develop Apr 4, 2023

LecrisUT deleted the rpm-spec branch April 4, 2023 22:53

Conversation

LecrisUT commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

lan496 commented Apr 2, 2023

rpm spec file

python optional dependencies

Uh oh!

LecrisUT commented Apr 2, 2023

python optional dependencies

Uh oh!

lan496 left a comment

Choose a reason for hiding this comment

Uh oh!

LecrisUT commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lan496 commented Apr 4, 2023

Uh oh!

lan496 commented Apr 4, 2023

Uh oh!

LecrisUT commented Apr 4, 2023

Uh oh!

LecrisUT commented Apr 5, 2023

Uh oh!

packit-as-a-service bot commented Apr 5, 2023

Uh oh!

packit-as-a-service bot commented Apr 5, 2023

Uh oh!

packit-as-a-service bot commented Apr 5, 2023

Uh oh!

LecrisUT commented Apr 5, 2023

Uh oh!

LecrisUT commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LecrisUT commented Mar 20, 2023 •

edited

Loading

codecov-commenter commented Mar 20, 2023 •

edited

Loading

LecrisUT commented Apr 4, 2023 •

edited

Loading