Skip to content

Update documentation link#253

Merged
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:doc-link
Mar 5, 2023
Merged

Update documentation link#253
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:doc-link

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Mar 1, 2023

The other note I had was about what do we do with previous versions? Do we want to recreate them, or should we just consider this version moving on to be maintained?

Closes: #252

@LecrisUT LecrisUT requested a review from lan496 March 1, 2023 10:16
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 1, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (e78c3de) 85.69% compared to head (7cf458e) 85.69%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #253   +/-   ##
========================================
  Coverage    85.69%   85.69%           
========================================
  Files           23       23           
  Lines         6069     6069           
========================================
  Hits          5201     5201           
  Misses         868      868
Flag Coverage Δ
c_api 73.70% <ø> (ø)
fortran_api 37.37% <ø> (ø)
python_api 82.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

lan496
lan496 reviewed Mar 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LecrisUT LGTM so far. How to redirect github.io to readthdocs.io? One way will be just to put index.html with a meta refresh tag.
https://gist.github.com/domenic/1f286d415559b56d725bee51a62c24a7

@atztogo I do not have permission to update the link on PyPI? Can you update it to https://spglib.readthedocs.io/ ?

@atztogo
Copy link
Copy Markdown
Collaborator

atztogo commented Mar 2, 2023

Maybe pyproject.toml to change URL link on PyPI?

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Mar 2, 2023

Ok, we should see it in test.pypi on the next rc then. I'll let you handle the github page redirect. Just make sure you do it for both the base and the spglub subfolder

lan496
lan496 approved these changes Mar 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll work the redirection on gh-pages branch after this PR is merged.

@LecrisUT LecrisUT merged commit 0866e94 into spglib:develop Mar 5, 2023
@lan496 lan496 mentioned this pull request Mar 5, 2023
Merged
@LecrisUT LecrisUT deleted the doc-link branch March 6, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan496 lan496 lan496 approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate github.io documentation

4 participants

@LecrisUT @codecov-commenter @atztogo @lan496