Skip to content

Use tag format for PyPi action#250

Merged
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:PyPi-action
Feb 28, 2023
Merged

Use tag format for PyPi action#250
LecrisUT merged 2 commits intospglib:developfrom
LecrisUT:PyPi-action

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Feb 24, 2023

This is taken from #241

@LecrisUT
Use tag format
daf51a6 
Signed-off-by: Cristian Le <[email protected]>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2023

Codecov Report

Base: 85.69% // Head: 73.92% // Decreases project coverage by -11.78% ⚠️

Coverage data is based on head (daf51a6) compared to base (bbb4f1e).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop     #250       +/-   ##
============================================
- Coverage    85.69%   73.92%   -11.78%     
============================================
  Files           23       22        -1     
  Lines         6069     5576      -493     
============================================
- Hits          5201     4122     -1079     
- Misses         868     1454      +586
Flag Coverage Δ
c_api 73.70% <ø> (ø)
fortran_api 37.37% <ø> (ø)
python_api ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/site_symmetry.c 52.55% <0.00%> (-45.41%) ⬇️
src/niggli.c 59.39% <0.00%> (-25.89%) ⬇️
src/overlap.c 71.85% <0.00%> (-21.11%) ⬇️
src/kpoint.c 77.72% <0.00%> (-20.09%) ⬇️
src/symmetry.c 62.22% <0.00%> (-18.48%) ⬇️
src/cell.c 64.52% <0.00%> (-14.96%) ⬇️
src/refinement.c 72.10% <0.00%> (-12.73%) ⬇️
src/sitesym_database.c 90.00% <0.00%> (-10.00%) ⬇️
src/msg_database.c 88.09% <0.00%> (-9.53%) ⬇️
src/spglib.c 63.48% <0.00%> (-9.42%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lan496
Copy link
Copy Markdown
Member

lan496 commented Feb 25, 2023

@LecrisUT Thanks. Can you update Contributing.md?

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Feb 25, 2023

Oh yeah, forgot about that

@LecrisUT
Update Contributing.md
601542d 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT LecrisUT requested a review from lan496 February 27, 2023 11:01
lan496
lan496 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lan496 lan496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LecrisUT The instruction of Contributing.md looks nice! I've checked to run wheel-building CI in my forked repo.
https://github.com/lan496/spglib/actions/runs/4289284752

@lan496 lan496 requested a review from atztogo February 28, 2023 04:27
@LecrisUT LecrisUT merged commit eec1fb6 into spglib:develop Feb 28, 2023
@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Feb 28, 2023

@lan496 can you edit the pyproject.toml and push tag v2.1.0-rc1?

@lan496
Copy link
Copy Markdown
Member

lan496 commented Feb 28, 2023

@LecrisUT Sure. Which branch is appropriate to push in this case?

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Feb 28, 2023

It is commit specific, but add a commit to edit pyproject.toml on develop and tag that commit.

@lan496
Copy link
Copy Markdown
Member

lan496 commented Feb 28, 2023

@LecrisUT I've pushed e78c3de to develop branch.

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Feb 28, 2023

Great, thanks. For some reason I am able to create releases, even though I can't push tags :))

@lan496
Copy link
Copy Markdown
Member

lan496 commented Feb 28, 2023

Sorry, I didn't notice "write" role cannot push tags. I'll add you "Maintain" role.
https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization

@LecrisUT
Copy link
Copy Markdown
Collaborator Author

LecrisUT commented Feb 28, 2023

Thanks, didn't know the difference in the roles either.

@LecrisUT LecrisUT deleted the PyPi-action branch March 1, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan496 lan496 lan496 approved these changes

@atztogo atztogo Awaiting requested review from atztogo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LecrisUT @codecov-commenter @lan496